[Kde-pim] Review Request: make autoSaveCopyResult conform
Guy Maurel
guy-kde at maurel.de
Sat Apr 9 19:00:58 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101072/
-----------------------------------------------------------
Review request for KDEPIM.
Summary
-------
Regarding to kdelibs/kdecore/jobs/kjobs.h at line 52:
if ( job->error() )
doSomething();
because of, at line 254:
@return the error code for this job, 0 if no error.
is the method autoSaveCopyResult not conform. It produces an error:
kmail-migrator(1691) KMail::KMailMigrator::autoSaveCopyResult: error= 0 text= "Unknown error code 0
I propose to add one line.
Diffs
-----
migration/kmail/kmailmigrator.cpp 7adeef8
Diff: http://git.reviewboard.kde.org/r/101072/diff
Testing
-------
Thanks,
Guy
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list