[Kde-pim] Review Request: Add minimum and maximum date limit options to KDateEdit

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5445/#review7784
-----------------------------------------------------------

Ship it!


please use the kdepim coding style.  other than that and my 1 little comment.. looks really nice


trunk/KDE/kdepim/libkdepim/kdateedit.cpp
<http://svn.reviewboard.kde.org/r/5445/#comment7920>

    isEmpty()


- Allen


On 2010-09-25 00:22:53, David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5445/
> -----------------------------------------------------------
> 
> (Updated 2010-09-25 00:22:53)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch is to add the option of setting a minimum and/or maximum date which the user can enter in KPIM::KDateEdit. By default, the current behaviour is unchanged, i.e. there are no limits. If the user tries to enter a date outside the range, an error message is displayed and the date is reset to the appropriate limit value.
> 
> KAlarm has used this functionality for a long time, by means of a class derived from KDateEdit. It would be better for future maintenance to incorporate it into the libkdepim class, especially before any move to kdelibs.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kalarm/alarmtimewidget.h 1179188 
>   trunk/KDE/kdepim/kalarm/alarmtimewidget.cpp 1179188 
>   trunk/KDE/kdepim/kalarm/lib/dateedit.h 1179188 
>   trunk/KDE/kdepim/kalarm/lib/dateedit.cpp 1179188 
>   trunk/KDE/kdepim/kalarm/recurrenceedit.h 1179188 
>   trunk/KDE/kdepim/kalarm/recurrenceedit.cpp 1179188 
>   trunk/KDE/kdepim/libkdepim/kdateedit.h 1179188 
>   trunk/KDE/kdepim/libkdepim/kdateedit.cpp 1179188 
> 
> Diff: http://svn.reviewboard.kde.org/r/5445/diff
> 
> 
> Testing
> -------
> 
> It works in KAlarm, in the New Alarm dialog.
> 
> 
> Thanks,
> 
> David
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/