[Kde-pim] Re: Review Request: Akonadi: Workaround for broken mimetype filtering

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5519/#review8304
-----------------------------------------------------------


Tricky one, fixed differently in revision 1188436 by Steve.

- Volker


On 2010-10-02 19:01:40, Peter Grasch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5519/
> -----------------------------------------------------------
> 
> (Updated 2010-10-02 19:01:40)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch provides a workaround to an issue in CollectionFetchJob when filtering for mimetypes.
> 
> Applications like KAddressBook use the EntityTreeView to display available collections by limiting the display to collections matching certain mimetypes. The CollectionFetchJob will then list all top level collections matching these mimetypes. If there is no matching top level collection the result set will be empty in the current implementation.
> 
> This means that when your contact collection is not a top level collection (for example when using the groupdav resource which groups all collections associated with one server in one top level collection), they will not show up in KAddressBook. The same goes for events in KOrganizer.
> 
> As soon as you add one matching top level collection all matching sub level collections will be displayed as well. See this bug report for more details: https://bugs.kde.org/show_bug.cgi?id=253054
> 
> The attached patch provides a simple workaround by adding "inode/directory" to the searched mimetypes to include all collections during lookup. Before emitting the result set, each collection will be checked if it matches the originally set mimetypes and if it does, this collection and all it's parents will be included in the final resultset.
> 
> Disclaimer: I am not an Akonadi developer. Up until yesterday I never even saw the Akonadi codebase so this might be in a completely wrong place.
> 
> 
> This addresses bug 253054.
>     https://bugs.kde.org/show_bug.cgi?id=253054
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/akonadi/collectionfetchjob.cpp 1181791 
> 
> Diff: http://svn.reviewboard.kde.org/r/5519/diff
> 
> 
> Testing
> -------
> 
> Tested it with the groupdav resource
> 
> 
> Thanks,
> 
> Peter
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/