[Kde-pim] Re: Review Request: KIMAP::FetchJob: add the ability to fetch custom headers

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5930/#review8892
-----------------------------------------------------------


Thanks for the patch :)
Two small inline comments below.


/trunk/KDE/kdepimlibs/kimap/fetchjob.h
<http://svn.reviewboard.kde.org/r/5930/#comment9607>

    The method can be const, I guess.
    
    Add @since 4.6 to the API documentation



/trunk/KDE/kdepimlibs/kimap/fetchjob.cpp
<http://svn.reviewboard.kde.org/r/5930/#comment9608>

    Use foreach(const QByteArray &header, ...), that is a bit faster since it doesn't copy the object (even though QByteArray is implicitly shared, it is still a bit slower).
    Also, const is always good.
    


- Thomas


On 2010-11-22 10:02:55, Gregory Schlomoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5930/
> -----------------------------------------------------------
> 
> (Updated 2010-11-22 10:02:55)
> 
> 
> Review request for KDE PIM and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> This patch adds the ability to fetch custom headers from messages (Like "X-Something"). Once fetched, the content of the headers is available through the headersByType method from KMime::Message
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/kimap/fetchjob.h 1199501 
>   /trunk/KDE/kdepimlibs/kimap/fetchjob.cpp 1199501 
> 
> Diff: http://svn.reviewboard.kde.org/r/5930/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregory
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/