[Kde-pim] Re: Review Request: KIMAP::FetchJob: add the ability to fetch custom headers

Gregory Schlomoff gregory.schlomoff at gmail.com
Mon Nov 22 10:39:40 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5930/
-----------------------------------------------------------

(Updated 2010-11-22 10:39:40.595754)


Review request for KDE PIM and Kevin Ottens.


Changes
-------

Changes:
- Added @since 4.6 to the API documentation
- Added an example to the documentation
- Used a const iterator

Not changed:
>The method can be const, I guess.
There is no getter / setter method, we are exposing the member variable publicly, following what is done for the "parts" member variable.


Summary
-------

This patch adds the ability to fetch custom headers from messages (Like "X-Something"). Once fetched, the content of the headers is available through the headersByType method from KMime::Message


Diffs (updated)
-----

  /trunk/KDE/kdepimlibs/kimap/fetchjob.h 1199501 
  /trunk/KDE/kdepimlibs/kimap/fetchjob.cpp 1199501 

Diff: http://svn.reviewboard.kde.org/r/5930/diff


Testing
-------


Thanks,

Gregory

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list