[Kde-pim] Re: Review Request: Bugfix in KIMAP::SelectJob: Q_ASSERT is failing when selecting a mailbox with special characters

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5929/#review8963
-----------------------------------------------------------


Hmm, somewhat looks like the wrong fix as we're supposed to have a decoded version of the current mailbox in the session object. So something it messed up somewhere, and likely on the Session side then.

In any case, please also add a unit test for this bug.

- Kevin


On 2010-11-23 04:20:44, Gregory Schlomoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5929/
> -----------------------------------------------------------
> 
> (Updated 2010-11-23 04:20:44)
> 
> 
> Review request for KDE PIM and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> When selecting a Mailbox with special characters in its name, like a forward slash, the Q_ASSERT from SelectJob is failing because d->m_session->selectedMailBox() != d->mailBox.
> 
> Checking against d->mailBox OR the encoded version of the mailbox name, with KIMAP::encodeImapFolderName(d->mailBox.toUtf8()), fixes this problem.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/kimap/selectjob.cpp 1199501 
> 
> Diff: http://svn.reviewboard.kde.org/r/5929/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregory
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/