[Kde-pim] Re: Mail migration issues caused by side effects

[laurent Montel]

Hi,
It's right I tested yesterday migration and saw these two problem :(
I didn't understand them.
So for 1) we can remove code which remove account if it creates problem.

I saw an other problem when we have an account (for example a test account) but 
we don't remember password (I have a account as it in my kmail1), we can't just 
"cancel" dialogbox but we can't say "Ignore this account" or "Delete this 
account" and each time we relauch kmail, kmail-migrator is relaunch... so not 
good.
I think it will a very good idea to allow to remove it.
(to fix this problem it was necessary to edit kmailrc and remove this account by 
hand but for end-user it will not do it...)

Regards

On dimanche 28 novembre 2010 21:10:40 Kevin Krammer wrote:
> Hi all,
> 
> while testing my fix for a filter migration problem (filters which only
> apply to a selection of inbound accounts), I ran into two issues caused by
> side effects of changes that by themselves look reasonable.
> 
> 1) Laurent added some new config cleanup code that removes all account
> groups from kmail2rc after migration is done.
> 
> Side effect: absence of account groups is a trigger to copy kmailrc to
> kmail2rc before migration, meaning any next run of kmail-migrator will
> overwrite all changes done by previous runs.
> 
> Issue: all already successfully migrated accounts are skipped, all filters
> are now unmigrated.
> 
> General additional problem: the cleanup code does not seem to check at all
> whether the account has been successfully migrated.
> 
> 2) Tobias removed a connect from the migrator's info dialog to the dialog's
> deleteLater() slot.
> 
> Side effect: the migrator does not exit anymore. Probably because the
> dialog is not destroyed elsewhere, so the KGlobal::deref() in its
> destructor is not called either.
> 
> Maybe we can discuss potential fixes through reviewboard in order to make
> it less likely to introduce just a different side effect.
> 
> Cheers,
> Kevin
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/