[Kde-pim] Review Request: Akonadi selt test for PostgreSQL should not connect as user akonadi

Brian DeRocher brian at derocher.org
Tue Mar 23 14:24:08 GMT 2010


Tobias,

Oh, i was expecting to see a comment on reviewboard, not here ;)

I've updated the request with a new diff.

http://reviewboard.kde.org/r/3339

On Sunday 21 March 2010 16:46:46 Tobias Koenig wrote:
> Instead of
> 
>   if(username != notNeeded)
> 
> you should use
> 
>   if ( !username.isEmpty() )

done

> > I have not run a regression test, but would be glad to if someone shows me how.
> Make sure you compiled kdepimlibs/akonadi with 'BUILD_TESTS = on' (this is a cmake option).
> Afterwards chdir into kdepimlibs/akonadi/tests and execute 'make test', this will run all
> unit tests. However there could be some wrong results because of some race conditions that
> haven't been fixed yet.

todo

Brian

--
http://brian.derocher.org
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list