[Kde-pim] Review Request: Akonadi selt test for PostgreSQL should not connect as user akonadi

Tobias Koenig tokoe at kde.org
Tue Mar 23 15:14:14 GMT 2010


On Tue, Mar 23, 2010 at 10:24:08AM -0400, Brian DeRocher wrote:
> Tobias,
Hej Brian,

> Oh, i was expecting to see a comment on reviewboard, not here ;)
/me was to lazy to start a graphical web browser to work with reviewboard ;)

> > Instead of
> > 
> >   if(username != notNeeded)
> > 
> > you should use
> > 
> >   if ( !username.isEmpty() )
> 
> done
Ok, looks good, do you have a SVN account? Otherwise I'd commit for you.

Ciao,
Tobias
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20100323/2a17c409/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list