[Kde-pim] Review Request: Fix crash when renaming folders after creating them.

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3314/#review4561
-----------------------------------------------------------

Ship it!


Looks good, please commit.

- Thomas


On 2010-03-17 12:04:01, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3314/
> -----------------------------------------------------------
> 
> (Updated 2010-03-17 12:04:01)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Fixes a crash when renaming folders after creating them.
> 
> The check that sees if mAccount is 0 should be before accessing mAccount.
> 
> ==8555==    at 0x98E7A8F: QMap<QString, KMAcctCachedImap::RenamedFolder>::find(QString const&) const (qmap.h:701)
> ==8555==    by 0x98E4D13: KMAcctCachedImap::renamedFolder(QString const&) const (kmacctcachedimap.cpp:477)       
> ==8555==    by 0x9905A2A: KMFolderCachedImap::rename(QString const&, KMFolderDir*) (kmfoldercachedimap.cpp:599)  
> ==8555==    by 0x9A70A74: KMail::RenameJob::execute() (renamejob.cpp:122)                                        
> ==8555==    by 0x99EF498: KMail::FolderJob::start() (folderjob.cpp:110)                                          
> ==8555==    by 0x9887688: KMFolderMgr::renameFolder(KMFolder*, QString const&, KMFolderDir*) (kmfoldermgr.cpp:585)
> ==8555==    by 0x9A00779: KMailICalIfaceImpl::changeResourceUIName(QString const&, QString const&) (kmailicalifaceimpl.cpp:1651)
> ==8555==    by 0x9AEB599: KMailICalIface::process(QCString const&, QMemArray<char> const&, QCString&, QMemArray<char>&) (kmailicalIface_skel.cpp:249)                                                                                                                                     
> ==8555==    by 0x5727709: DCOPClient::receive(QCString const&, QCString const&, QCString const&, QMemArray<char> const&, QCString&, QMemArray<char>&) (dcopclient.cpp:1643)                                                                                                               
> ==8555==    by 0x572AF18: DCOPClient::call(QCString const&, QCString const&, QCString const&, QMemArray<char> const&, QCString&, QMemArray<char>&, bool, int) (dcopclient.cpp:1751)                                                                                                       
> ==8555==    by 0x5720396: DCOPRef::callInternal(QCString const&, QCString const&, QMemArray<char> const&, DCOPRef::EventLoopFlag, int) (dcopref.cpp:77)                                                                                                                                   
> ==8555==    by 0x57203FD: DCOPRef::callInternal(QCString const&, QCString const&, QMemArray<char> const&) (dcopref.cpp:52)                   
> ==8555==  Address 0x1fc is not stack'd, malloc'd or (recently) free'd  
> 
> 
> This addresses bug kolab/issue3658.
>     https://bugs.kde.org/show_bug.cgi?id=kolab/issue3658
> 
> 
> Diffs
> -----
> 
>   branches/kdepim/enterprise/kdepim/kmail/kmfoldercachedimap.cpp 1104304 
> 
> Diff: http://reviewboard.kde.org/r/3314/diff
> 
> 
> Testing
> -------
> 
> Tried many combinations:
> creating folder in kmail, renaming in korganizer
> creating folder in korganizer, renaming in kmail
> creating folder in korganizer, renaming in korganizer
> etc.
> 
> 
> Thanks,
> 
> Sergio
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/