[Kde-pim] Review Request: Using QLatin1String in methods startsWith and endsWith

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3389/#review4676
-----------------------------------------------------------

Ship it!


Thanks, please commit after changing the coding style.


trunk/KDE/kdepim/kmail/kmcommands.cpp
<http://reviewboard.kde.org/r/3389/#comment4182>

    The coding style in KDEPIM is to have spaces at the inside of parentheses, so this would be ( ".mbox" ).
    
    Same at the other places.


- Thomas


On 2010-03-24 21:51:49, Ronny Yabar Aizcorbe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3389/
> -----------------------------------------------------------
> 
> (Updated 2010-03-24 21:51:49)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Pass QLatin1String to methods startsWith and endsWith is more efficient because it avoids an implicit conversion from const char *
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kmail/kmcommands.cpp 1107082 
>   trunk/KDE/kdepim/kmail/messageactions.cpp 1107082 
> 
> Diff: http://reviewboard.kde.org/r/3389/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ronny
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/