[Kde-pim] Review Request: kmail - please add ability to display and sort by date received

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4337/#review6162
-----------------------------------------------------------


Thanks for coming up with a patch for this for SVN trunk!

Like Ingo, I'm not sure if using the Received header is the best idea here.
For sorting by date of arrival, I would suggest simply comparing the item id, since the item id is strictly increasing. This was the way KMail 1 worked as well, it compared the serial number, which is the equivalent of the Akonadi item id.

Ingo, I don't agree that this feature is not needed. KMail had it earlier, before the new message list was introduced, and now we got some bug reports about this feature missing.

I wonder what the best UI would be. Before, you could toggle the between sorting by date and sorting by date of arrival simply by clicking on the date header in the view. I think it would be nice to have the same behaviour, in addition to having the new sort mode in the sort mode menu.

- Thomas


On 2010-06-16 01:03:47, Eric Sanford wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4337/
> -----------------------------------------------------------
> 
> (Updated 2010-06-16 01:03:47)
> 
> 
> Review request for KDE PIM and Thomas McGuire.
> 
> 
> Summary
> -------
> 
> KMail should have the ability to extract the date from the Received header field, display the date received and sort by date received. A significant number of emails have incorrect or missing Date header fields. When sorting by Date in KMail, these drop to the bottom as Unknown or appear at the top if the Date header field contains a future date. This is a basic patch to extract the date from the Received header field, add a Date Received column in KMail classic theme, and sort by Date Received in classic theme. This is industry-standard for comparable email applications.
> 
> 
> This addresses bug 227942.
>     https://bugs.kde.org/show_bug.cgi?id=227942
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/messagelist/core/item.h 1137450 
>   trunk/KDE/kdepim/messagelist/core/item.cpp 1137450 
>   trunk/KDE/kdepim/messagelist/core/item_p.h 1137450 
>   trunk/KDE/kdepim/messagelist/core/manager.cpp 1137450 
>   trunk/KDE/kdepim/messagelist/core/model.cpp 1137450 
>   trunk/KDE/kdepim/messagelist/core/sortorder.h 1137450 
>   trunk/KDE/kdepim/messagelist/core/sortorder.cpp 1137450 
>   trunk/KDE/kdepim/messagelist/core/theme.h 1137450 
>   trunk/KDE/kdepim/messagelist/core/theme.cpp 1137450 
>   trunk/KDE/kdepim/messagelist/core/themedelegate.cpp 1137450 
>   trunk/KDE/kdepim/messagelist/core/view.cpp 1137450 
>   trunk/KDE/kdepim/messagelist/storagemodel.cpp 1137450 
>   trunk/KDE/kdepim/messagelist/utils/themeeditor.cpp 1137450 
>   trunk/KDE/kdepim/nepomuk_email_feeder/messageanalyzer.cpp 1137450 
>   trunk/KDE/kdepimlibs/kmime/kmime_headers.h 1137426 
>   trunk/KDE/kdepimlibs/kmime/kmime_headers.cpp 1137426 
>   trunk/KDE/kdepimlibs/kmime/kmime_headers_p.h 1137426 
>   trunk/KDE/kdepimlibs/kmime/kmime_message.h 1137426 
>   trunk/KDE/kdepimlibs/kmime/kmime_message.cpp 1137426 
> 
> Diff: http://reviewboard.kde.org/r/4337/diff
> 
> 
> Testing
> -------
> 
> This patch has been tested on openSUSE 11.2 and openSUSE 11.3 Milestone 7. The attached patch is currently being tested on openSUSE 11.3 Milestone 7, with KDE executables and libraries built from trunk/KDE (revision 1137426) source code for kdelibs, kdepimlibs, kdebase and kdepim, and trunk/kdesupport source code for attica, soprano, polkit-qt, and akonadi.
> 
> 
> Thanks,
> 
> Eric
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/