[Kde-pim] Review Request: Add text direction switch buttons to KRichTextEdit, and use that in KMail

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4187/#review5945
-----------------------------------------------------------


Looks very well overall, thank you for your work.
I've made some smaller comments inline below.


/trunk/KDE/kdelibs/kdeui/widgets/krichtextedit.h
<http://reviewboard.kde.org/r/4187/#comment5564>

    "make" sounds very generic for the method name, can you come up with a better verb here?



/trunk/KDE/kdelibs/kdeui/widgets/krichtextedit.cpp
<http://reviewboard.kde.org/r/4187/#comment5565>

    In kdelibs, please use 4 spaces as indentation.



/trunk/KDE/kdelibs/kdeui/widgets/krichtextwidget.h
<http://reviewboard.kde.org/r/4187/#comment5566>

    Use spaces here, not tabs



/trunk/KDE/kdelibs/kdeui/widgets/krichtextwidget.cpp
<http://reviewboard.kde.org/r/4187/#comment5567>

    No need for double parenthesis



/trunk/KDE/kdelibs/kdeui/widgets/krichtextwidget.cpp
<http://reviewboard.kde.org/r/4187/#comment5568>

    add const here, i.e.
    const Qt::LayoutDirection direction =



/trunk/KDE/kdelibs/kdeui/widgets/krichtextwidget.cpp
<http://reviewboard.kde.org/r/4187/#comment5569>

    I guess the actions should also be disabled when appropriate?
    For example, when the text direction is already RTL, then the RTL button should be disabled.



/trunk/KDE/kdepim/kmail/kmcomposerui.rc
<http://reviewboard.kde.org/r/4187/#comment5570>

    Should the actions really be in the HTML toolbar? Text direction is not something people would associate with HTML, I think.
    
    So maybe add it to the general toolbar. Or maybe even create a "direction" toolbar, and only show that by default if the user is in a RTL locale.


- Thomas


On 2010-05-31 22:29:26, Mohammad Ebrahim Mohammadi Panah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4187/
> -----------------------------------------------------------
> 
> (Updated 2010-05-31 22:29:26)
> 
> 
> Review request for KDE PIM and Thomas McGuire.
> 
> 
> Summary
> -------
> 
> Add text direction switch buttons to KRichTextEdit, and use that in KMail
> 
> 
> This addresses bug 181311.
>     https://bugs.kde.org/show_bug.cgi?id=181311
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/widgets/krichtextedit.h 1132977 
>   /trunk/KDE/kdelibs/kdeui/widgets/krichtextedit.cpp 1132977 
>   /trunk/KDE/kdelibs/kdeui/widgets/krichtextwidget.h 1132977 
>   /trunk/KDE/kdelibs/kdeui/widgets/krichtextwidget.cpp 1132977 
>   /trunk/KDE/kdepim/kmail/kmcomposerui.rc 1132977 
>   /trunk/KDE/kdepim/kmail/kmcomposewin.cpp 1132977 
> 
> Diff: http://reviewboard.kde.org/r/4187/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mohammad Ebrahim
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/