[Kde-pim] [PATCH] backport of contact autocompletion for kmail 4.4

[Kevin Krammer]

Hi Tobias,

On Friday, 2010-06-25, Tobias Koenig wrote:
> Hej,
> 
> the attached two patches (for kdepim and kdepimlibs module) backport the
> autocompletion for contacts and contact groups to the 4.4 branch.
> 
> Since autocompletion is an essential part of the workflow when sending
> emails and it worked in 4.3 (without Akonadi) without problems, I'd like
> to declare it as an regression and this backport as a bugfix.
> 
> Any objections to commit these patches to 4.4 branch to get them included
> into the 4.4.5 release?

I agree on this being a regression and having to be fixed. However, I think 
that adding to the public API should still be avoided.
The headers will end up in the development packages, people looking at them 
might thing that this is 4.4 API.

You might have to copy the classes to KDEPIM and modify them there :(

On the code itself: in "perform search", wouldn't it make sense to check if a 
search for the same string is already running to avoid starting the same 
search again?

It also seems to not clear the result of the previous search, but I could have 
misunderstood that part.

Cheers,
Kevin

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20100625/798e6b67/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/