[Kde-pim] [PATCH] backport of contact autocompletion for kmail 4.4

[Tobias Koenig]

On Fri, Jun 25, 2010 at 11:54:00AM +0200, Kevin Krammer wrote:
> Hi Tobias,
Hej Kevin,

> > Any objections to commit these patches to 4.4 branch to get them included
> > into the 4.4.5 release?
> 
> I agree on this being a regression and having to be fixed. However, I think 
> that adding to the public API should still be avoided.
> The headers will end up in the development packages, people looking at them 
> might thing that this is 4.4 API.
> 
> You might have to copy the classes to KDEPIM and modify them there :(
True, shouldn't be a problem, will do so and provide new patches!

@Thomas: it seems the 'akonadiItemId' checks are missing in the ContactSearchJob
in 4.4, also this attribute is added by the nepomuk_contact_feeder from 4.4
(was a backport by Will iirc). So shall I provide a separate patch that adds the
'akonadiItemId' check in ContactSearchJob to improve performance?

> On the code itself: in "perform search", wouldn't it make sense to check if a 
> search for the same string is already running to avoid starting the same 
> search again?
> 
> It also seems to not clear the result of the previous search, but I could have 
> misunderstood that part.
Well, that's actually a 1:1 copy of our code in KDE trunk, I haven't changed anything ;)

Ciao,
Tobias
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20100625/bc1cbea1/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/