[Kde-pim] Review Request: Port KAlarm to KStatusNotifierItem

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3374/
-----------------------------------------------------------

(Updated 2010-07-07 10:57:03.597711)


Review request for KDE PIM and David Jarvie.


Changes
-------

Fixed some issues with the system tray hiding:
- Bring the main window to front if it is hidden and user disable the tray icon from the configuration dialog
- If the tray icon was disabled and the user clicked the close button of the main window title bar, the window would not close


Summary
-------

This is a port of KAlarm from KSystemTrayIcon to KStatusNotifierItem. Note that it makes use of overlays, so I created (warning, hacker "art"!) two emblems for it, which you can download here:
http://people.canonical.com/~agateau/tmp/ox8-emblems-disabled.png
http://people.canonical.com/~agateau/tmp/ox8-emblems-partdisabled.png

The emblems should be placed in kalarm/pixmaps/

(The ox22-emblems-partdisabled.png file from this dir can be removed)

Unfortunately, there is no way for a KStatusNotifierItem to be notified when the tooltip is about to be displayed so I had to resort to add code which updates the tooltip whenever necessary.


Diffs (updated)
-----

  trunk/KDE/kdepim/kalarm/kalarmapp.cpp 1146866 
  trunk/KDE/kdepim/kalarm/kalarmconfig.kcfg 1146866 
  trunk/KDE/kdepim/kalarm/mainwindow.cpp 1146866 
  trunk/KDE/kdepim/kalarm/traywindow.h 1146866 
  trunk/KDE/kdepim/kalarm/traywindow.cpp 1146866 

Diff: http://reviewboard.kde.org/r/3374/diff


Testing
-------

- Created tasks, disabled some of them, disabled the whole of kalarm: icon was correctly updated.
- Checked the tooltip is always up to date, including when it is setup to show the remaining time of an alarm and including following tooltip preferences changes.


Thanks,

Aurélien

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/