[Kde-pim] Review Request: Translate collection subscribed/unsubscribed notifications to new Monitor signals, and watch them in ETM to show/hide the added/removed collections.

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4769/#review6731
-----------------------------------------------------------


There should be a description in the apidox of what "subscribed" means. You shouldn't assume that a developer will know (I don't, for one). 

- David


On 2010-07-28 15:39:43, Leo Franchi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4769/
> -----------------------------------------------------------
> 
> (Updated 2010-07-28 15:39:43)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> There was no way for the ETM to know when a collection was subscribed or unsubscribed to. This allows clients to handle this case.
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.5/kdepimlibs/akonadi/entitytreemodel_p.cpp 1155996 
>   /branches/KDE/4.5/kdepimlibs/akonadi/monitor.h 1155996 
>   /branches/KDE/4.5/kdepimlibs/akonadi/monitor_p.cpp 1155996 
> 
> Diff: http://reviewboard.kde.org/r/4769/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leo
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/