[Kde-pim] Review Request: Translate collection subscribed/unsubscribed notifications to new Monitor signals, and watch them in ETM to show/hide the added/removed collections.

Stephen Kelly steveire at gmail.com
Thu Jul 29 13:18:42 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4769/#review6737
-----------------------------------------------------------

Ship it!


The comment in monitor dates from an earlier patch I think.

Apart from that, please create new slots for the {un,}subscription and forward to the added/removed slots.

- Stephen


On 2010-07-28 15:39:43, Leo Franchi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4769/
> -----------------------------------------------------------
> 
> (Updated 2010-07-28 15:39:43)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> There was no way for the ETM to know when a collection was subscribed or unsubscribed to. This allows clients to handle this case.
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.5/kdepimlibs/akonadi/entitytreemodel_p.cpp 1155996 
>   /branches/KDE/4.5/kdepimlibs/akonadi/monitor.h 1155996 
>   /branches/KDE/4.5/kdepimlibs/akonadi/monitor_p.cpp 1155996 
> 
> Diff: http://reviewboard.kde.org/r/4769/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leo
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list