[Kde-pim] Review Request: Renable network detection

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4626/#review6571
-----------------------------------------------------------

Ship it!


Fine with me, I never had problems with this.

- Volker


On 2010-07-14 12:04:15, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4626/
> -----------------------------------------------------------
> 
> (Updated 2010-07-14 12:04:15)
> 
> 
> Review request for KDE PIM, Kevin Ottens and Till Adam.
> 
> 
> Summary
> -------
> 
> Enable the Solid based network online detection code instead of hardcoding network resources to "online".
> 
> When the kded module for network detection is not present, Solid will report the network state as "unknown" which also result in online==true
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.5/kdepim/runtime/resources/imap/imapresource.cpp 1149760 
>   /branches/KDE/4.5/kdepimlibs/akonadi/agentbase.cpp 1149760 
> 
> Diff: http://reviewboard.kde.org/r/4626/diff
> 
> 
> Testing
> -------
> 
> Tested on Debian/Unstable using NetworkManager 0.8
> Activating/Deactivating my wireless connection changes IMAP resource's online state as expected
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/