[Kde-pim] Review Request: Fix a recursive loop in TransportManager

[Olivier Trichet]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2579/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

Fix a loop retrieving the password of a mail transport when TransportManager::schedule() is used and the stored password is empty.

[...]
#9719 0x00007fffef31f979 in MailTransport::TransportManager::loadPasswords (this=0x1144550) at /home/kde/dev/src/kdepimlibs/mailtransport/transportmanager.cpp:629
#9720 0x00007fffef31675a in MailTransport::Transport::password (this=0x11834c0) at /home/kde/dev/src/kdepimlibs/mailtransport/transport.cpp:82
#9721 0x00007fffef3386ef in MailTransport::SmtpJob::startSmtpJob (this=0x1187410) at /home/kde/dev/src/kdepimlibs/mailtransport/smtpjob.cpp:159
#9722 0x00007fffef337c1e in MailTransport::SmtpJob::doStart (this=0x1187410) at /home/kde/dev/src/kdepimlibs/mailtransport/smtpjob.cpp:114
#9723 0x00007fffef335344 in MailTransport::TransportJob::start (this=0x1187410) at /home/kde/dev/src/kdepimlibs/mailtransport/transportjob.cpp:129
#9724 0x00007fffef31f979 in MailTransport::TransportManager::loadPasswords (this=0x1144550) at /home/kde/dev/src/kdepimlibs/mailtransport/transportmanager.cpp:629
[...]


Note: only, one of the change below is necessary, but doing both does not hurt.


Diffs
-----

  trunk/KDE/kdepimlibs/mailtransport/transport.cpp 1074347 
  trunk/KDE/kdepimlibs/mailtransport/transportmanager.cpp 1074347 

Diff: http://reviewboard.kde.org/r/2579/diff


Testing
-------

Only check that passwords are still retrieve from the wallet.


Thanks,

Olivier

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/