[Kde-pim] Review Request: Fix a recursive loop in TransportManager

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2579/#review3724
-----------------------------------------------------------

Ship it!


I have honestly no idea about the complex password loading logic, so I just say "Ship it".
It would be nice if someone who remembers this code could review this as well.

1 inline comment below, answering your comment.


trunk/KDE/kdepimlibs/mailtransport/transport.cpp
<http://reviewboard.kde.org/r/2579/#comment3086>

    You can have transport objects that are not (yet) manager by the TransportManager.
    
    In this case, TransportManager::transportById() would return something else than 'this', since 'this' can be a copy of the transport, that has the same id.
    
    I have no idea if that is relevant here.


- Thomas


On 2010-01-14 02:06:06, Olivier Trichet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2579/
> -----------------------------------------------------------
> 
> (Updated 2010-01-14 02:06:06)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Fix a loop retrieving the password of a mail transport when TransportManager::schedule() is used and the stored password is empty.
> 
> [...]
> #9719 0x00007fffef31f979 in MailTransport::TransportManager::loadPasswords (this=0x1144550) at /home/kde/dev/src/kdepimlibs/mailtransport/transportmanager.cpp:629
> #9720 0x00007fffef31675a in MailTransport::Transport::password (this=0x11834c0) at /home/kde/dev/src/kdepimlibs/mailtransport/transport.cpp:82
> #9721 0x00007fffef3386ef in MailTransport::SmtpJob::startSmtpJob (this=0x1187410) at /home/kde/dev/src/kdepimlibs/mailtransport/smtpjob.cpp:159
> #9722 0x00007fffef337c1e in MailTransport::SmtpJob::doStart (this=0x1187410) at /home/kde/dev/src/kdepimlibs/mailtransport/smtpjob.cpp:114
> #9723 0x00007fffef335344 in MailTransport::TransportJob::start (this=0x1187410) at /home/kde/dev/src/kdepimlibs/mailtransport/transportjob.cpp:129
> #9724 0x00007fffef31f979 in MailTransport::TransportManager::loadPasswords (this=0x1144550) at /home/kde/dev/src/kdepimlibs/mailtransport/transportmanager.cpp:629
> [...]
> 
> 
> Note: only, one of the change below is necessary, but doing both does not hurt.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/mailtransport/transport.cpp 1074347 
>   trunk/KDE/kdepimlibs/mailtransport/transportmanager.cpp 1074347 
> 
> Diff: http://reviewboard.kde.org/r/2579/diff
> 
> 
> Testing
> -------
> 
> Only check that passwords are still retrieve from the wallet.
> 
> 
> Thanks,
> 
> Olivier
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/