[Kde-pim] Review Request: Processed and HTML sources tabs added to MessageSourceViewer

[Torgny Nyblom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2730/
-----------------------------------------------------------

(Updated 2010-01-26 09:26:34.253073)


Review request for KDE PIM.


Changes
-------

Fixed all issues raised by Thomas.


Summary
-------

Add two tabs to the MessageSourceViewer. One for the source after being processed and one for the html source used to render the message.
I think these two can be useful but perhaps not for everyone. An option would be to hide these tabs behind a hidden setting (developerExtras or something like that), but where should this setting go? I didn't find where to add this inside the MessageViewer.

There might be better texts for the tab labels.


This addresses bug 223845.
    https://bugs.kde.org/show_bug.cgi?id=223845


Diffs (updated)
-----

  /trunk/KDE/kdepim/messageviewer/mailsourceviewer.h 1080057 
  /trunk/KDE/kdepim/messageviewer/mailsourceviewer.cpp 1080057 
  /trunk/KDE/kdepim/messageviewer/viewer_p.cpp 1080139 

Diff: http://reviewboard.kde.org/r/2730/diff


Testing
-------

Sources shown in KMail.


Thanks,

Torgny

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/