[Kde-pim] Review Request: Processed and HTML sources tabs added to MessageSourceViewer

[Torgny Nyblom]

> On 2010-01-25 20:20:32, Ingo Klöcker wrote:
> > This is only useful for developers. As such, it should be completely separated from the MessageSourceViewer which is at least remotely useful for some users of KMail. In fact, it should also be completely separated from the MessageSourceViewer because separation of concerns is a corner stone of object oriented programming and ensures that something of the size of KMail stays maintainable.
> > 
> > For developers this functionality would surely be a nice tool for debugging. So I'm all for adding it as long as it's cleanly separated from the rest of the message viewer. I don't have a good suggestion how to make it available to developers in the menus without confusing users. Maybe via a configuration setting "Enable development tools". (?)
> 
> Tom Albers wrote:
>     +1. I would put it in akonadiconsole for example.
> 
> Thomas McGuire wrote:
>     > This is only useful for developers.
>     
>     I disagree, at least for the second tab, which shows the processed mail. That is useful for viewing the source of decrypted messages, for example.
>     
>     The third tab is another story: Maybe only show it in Akonadiconsole, or only in debug mode.

I disagree that it should be separated from MessageSourceViewer since from where I'm standing all the tabs show message sources, just from different phases of the mails life.

But I'm all for hiding the two new tabs behind a "developer" setting. But where should this setting go (in the UI, if at all, and for the kcfg)?


- Torgny


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2730/#review3879
-----------------------------------------------------------


On 2010-01-25 20:00:36, Torgny Nyblom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2730/
> -----------------------------------------------------------
> 
> (Updated 2010-01-25 20:00:36)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Add two tabs to the MessageSourceViewer. One for the source after being processed and one for the html source used to render the message.
> I think these two can be useful but perhaps not for everyone. An option would be to hide these tabs behind a hidden setting (developerExtras or something like that), but where should this setting go? I didn't find where to add this inside the MessageViewer.
> 
> There might be better texts for the tab labels.
> 
> 
> This addresses bug 223845.
>     https://bugs.kde.org/show_bug.cgi?id=223845
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/messageviewer/mailsourceviewer.h 1080057 
>   /trunk/KDE/kdepim/messageviewer/mailsourceviewer.cpp 1080057 
>   /trunk/KDE/kdepim/messageviewer/viewer_p.cpp 1080139 
> 
> Diff: http://reviewboard.kde.org/r/2730/diff
> 
> 
> Testing
> -------
> 
> Sources shown in KMail.
> 
> 
> Thanks,
> 
> Torgny
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/