[Kde-pim] Review Request: Possible fix for KMail's KMReaderWin::setMsg()

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2370/#review3767
-----------------------------------------------------------


Closing this as discarded, no feedback and trunk is a different story anyway.

- Thomas


On 2009-12-13 23:54:53, Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2370/
> -----------------------------------------------------------
> 
> (Updated 2009-12-13 23:54:53)
> 
> 
> Review request for KDE PIM and Thomas McGuire.
> 
> 
> Summary
> -------
> 
> Here's a patch for KMReaderWin::setMsg() that fixes some crashes by exiting before getting to updateReaderWin() in the aMsg == message() case.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1062157 
> 
> Diff: http://reviewboard.kde.org/r/2370/diff
> 
> 
> Testing
> -------
> 
> I was encountering lots of crashes before the patch and haven't had any crashes since.  Not a scientific test, admittedly. But that's why we have code review :)
> 
> 
> Thanks,
> 
> Allen
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/