[Kde-pim] Review Request: korg: Disable Zoom, Day, Work Week and Week buttons when we can't use them

[Sergio Martins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2649/
-----------------------------------------------------------

(Updated 2010-01-23 00:40:59.398478)


Review request for KDE PIM.


Changes
-------

Forgot to add select_nextx (next 3 days), it's also a range selection button that currently does nothing in month/todo-view.

Refactored the code to use a for loop instead of having 4 duplicated code blocks.


Summary
-------

According to Volker, beginning with 4.5, "Day", "Week" and "Work Week" buttons are no longer used for view selection but for date range selection. They are no longer tied to agenda. Now you can use them in timespent, timeline, journal-view, etc.

This patch disables them when in month and to-do view since they do nothing there ( besides confusing users ).

It also disables the zoom buttons on views that don't support zooming.


Diffs (updated)
-----

  trunk/KDE/kdepim/korganizer/actionmanager.cpp 1078804 
  trunk/KDE/kdepim/korganizer/interfaces/korganizer/baseview.h 1078804 
  trunk/KDE/kdepim/korganizer/interfaces/korganizer/baseview.cpp 1078804 
  trunk/KDE/kdepim/korganizer/koviewmanager.cpp 1078804 
  trunk/KDE/kdepim/korganizer/views/agendaview/agendaview.h 1078804 
  trunk/KDE/kdepim/korganizer/views/monthview/monthview.h 1078804 
  trunk/KDE/kdepim/korganizer/views/todoview/kotodoview.h 1078804 

Diff: http://reviewboard.kde.org/r/2649/diff


Testing
-------


Thanks,

Sergio

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/