[Kde-pim] Review Request: korg: refactor agenda layout management code

Sergio Martins iamsergio at gmail.com
Tue Feb 2 00:28:08 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2780/
-----------------------------------------------------------

Review request for KDE PIM and Allen Winter.


Summary
-------

Moved the agenda "merged/side by side/tabbed" management into the view manager and simplified the code as the logic is already inside showAgendaView() , so a call is enough to make the agenda layout adjustments.

Also fixes a crash in my flicker free patch (r1081695).


Diffs
-----

  trunk/KDE/kdepim/korganizer/calendarview.cpp 1083778 
  trunk/KDE/kdepim/korganizer/koviewmanager.h 1083778 
  trunk/KDE/kdepim/korganizer/koviewmanager.cpp 1083778 

Diff: http://reviewboard.kde.org/r/2780/diff


Testing
-------

Tested all combinations (agenda to multi, multi to agenda, multi to tabbed, etc) and the same while starting with month view.


Thanks,

Sergio

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list