[Kde-pim] Review Request: Add the item id to the Nepomuk resource when indexing

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3038/#review4259
-----------------------------------------------------------

Ship it!


Just adding some reminders for myself.
Ok'd on IRC by Volker and Sebastian Trüg.


trunk/KDE/kdepim/runtime/agents/nepomukfeeder/nepomukfeederagentbase.cpp
<http://reviewboard.kde.org/r/3038/#comment3780>

    Make this http://akonadi-project.org/ontologies/aneo#akonadiItemId



trunk/KDE/kdepim/runtime/agents/nepomukfeeder/nepomukfeederagentbase.cpp
<http://reviewboard.kde.org/r/3038/#comment3779>

    Don't create a QUrl from a string, use the string directly.


- Thomas


On 2010-02-22 20:39:41, Thomas McGuire wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3038/
> -----------------------------------------------------------
> 
> (Updated 2010-02-22 20:39:41)
> 
> 
> Review request for KDE PIM and Sebastian Trueg.
> 
> 
> Summary
> -------
> 
> This patch adds to Akonadi Item ID to all objects that are indexed by the Nepomuk feeders.
> With this, it is possible to create SPARQL queries that only return results that are actually Akonadi objects. We can not use other results anyway in the Akonadi server.
> After this patch is applied, the ContactSearchJob in kdepimlibs needs to be modified to include this new property.
> 
> Some open questions
> - the URI needs to be something more fancy than "AkonadiItemId", without any prefix. What should be used here?
> - This change triggers a reindex of all items, which calls removeEntityFromNepomuk() for each item. Doesn't this destroy all user tags and annotations? This worries me, 
>   since removeEntityFromNepomuk() is also called from itemChanged(), which would mean tags and annotations get lost every time something at the item changes...
> 
> 
> This addresses bug 219687.
>     https://bugs.kde.org/show_bug.cgi?id=219687
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/runtime/agents/nepomukfeeder/nepomukfeederagentbase.cpp 1093268 
> 
> Diff: http://reviewboard.kde.org/r/3038/diff
> 
> 
> Testing
> -------
> 
> Just did some test queries with sopranocmd that searched only for stuff with this property set, seemed to work fine
> 
> 
> Thanks,
> 
> Thomas
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/