[Kde-pim] Review Request: Use the same namespace as the messageviewer settings

Torgny Nyblom kde at nyblom.org
Sun Feb 14 20:14:05 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2914/#review4151
-----------------------------------------------------------

Ship it!


Makes sense to wrap the settings in the same namespace as everything else in the messageviewer.

- Torgny


On 2010-02-14 10:54:58, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2914/
> -----------------------------------------------------------
> 
> (Updated 2010-02-14 10:54:58)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Fixes the assert I was getting.
> ASSERT: "!s_globalGlobalSettingsBase->q" in file /g/build/kdepim/kmail/globalsettings_base.cpp, line 34
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/messageviewer/globalsettings_base.kcfgc 1089853 
> 
> Diff: http://reviewboard.kde.org/r/2914/diff
> 
> 
> Testing
> -------
> 
> No more this crash. I see now the kmail windows.
> 
> 
> Thanks,
> 
> Jaime
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list