[Kde-pim] Review Request: update new window/tab handling, add user option for new tab

[Frank Osterfeld]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3008/#review4320
-----------------------------------------------------------

Ship it!


- Frank


On 2010-02-26 13:25:22, Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3008/
> -----------------------------------------------------------
> 
> (Updated 2010-02-26 13:25:22)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch fixes some anomalies in Akregator's new window/tab handling, and adds a configuration option (with GUI) to open a link which would normally open in an external browser in a new tab instead (as for the same option in Konqueror).
> 
> The situations that it fixes are:
> 
> A page in a browser tab has link with TARGET="_blank".  Currently this ignores the link target and displays the new page in the same tab.  With the patch, the link is opened in a new tab or external browser (depending on the option setting).
> 
> A page in the article viewer has a link with TARGET="_blank".  Currently this ignores the link target and displays the new page in a new tab.  With the patch, the link is opened in a new tab or external browser (depending on the option).
> 
> In the 2 situations above, when a new tab is opened, the existing user preference for the left mouse button is checked.  If this is "open link in background tab", it is assumed that the user wants the new tab to also open in the background and this is what happens;  if the setting is "open in tab" then the new tab is opened and brought to the front.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akregator/configuration/settings_browser.ui 1091671 
>   /trunk/KDE/kdepim/akregator/interfaces/akregator.kcfg 1091671 
>   /trunk/KDE/kdepim/akregator/src/articleviewer.cpp 1096260 
>   /trunk/KDE/kdepim/akregator/src/framemanager.cpp 1096260 
>   /trunk/KDE/kdepim/akregator/src/openurlrequest.cpp 1096260 
> 
> Diff: http://reviewboard.kde.org/r/3008/diff
> 
> 
> Testing
> -------
> 
> Checked current trunk Akregator with this patch on a variety of news feeds and target web pages, confirmed behaviour is as expected.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/