[Kde-pim] Re: Review Request: Fix the rest of the 223477 bug

[Andras Mantia]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6033/#review9100
-----------------------------------------------------------

Ship it!


I see no reason for having there the location name, and a read only edit box is...very bad usability.

- Andras


On 2010-12-02 20:10:02, Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6033/
> -----------------------------------------------------------
> 
> (Updated 2010-12-02 20:10:02)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Hello
> 
> This is the first time that i am creating a patch for the kmail, so don't hesitate to correct me if i am wrong. :) This patch is removing the "Location" field from the maintenance of the kmai2... The rest of the bugs has been fixed by Tobias Koenig in the review 1200831. I have attach two snapshots with my patch.. The one before i make any changes and the other after the changes. If you think that something else needs to be removed or changed, then let me know... 
> 
> 
> This addresses bug 223477.
>     https://bugs.kde.org/show_bug.cgi?id=223477
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kmail/collectionmaintenancepage.h 1202671 
>   trunk/KDE/kdepim/kmail/collectionmaintenancepage.cpp 1202671 
> 
> Diff: http://svn.reviewboard.kde.org/r/6033/diff
> 
> 
> Testing
> -------
> 
> Everything compiles fine and the patch is working without any issue....
> 
> 
> Screenshots
> -----------
> 
> before 
>   http://svn.reviewboard.kde.org/r/6033/s/569/
> after
>   http://svn.reviewboard.kde.org/r/6033/s/570/
> 
> 
> Thanks,
> 
> Antonis
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/