[Kde-pim] Re: Review Request: Support recursive collection syncronization
Andras Mantia
amantia at kde.org
Sun Dec 12 13:16:43 GMT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6083/
-----------------------------------------------------------
(Updated 2010-12-12 13:16:42.876468)
Review request for KDE PIM.
Changes
-------
Use F5 for non-recursive sync, CTRL-F5 for recursive. If the strings are approved, I'll commit as it is, otherwise without the extra standard action (only the resourcebase part).
Summary
-------
As a user I'd expect that syncing a kmail folder syncronizes the folder and its subfolders. Might be useful in other cases as well. This patch implements this in resourcebase and agentmanager and adds a new action to the standard actions. F5 is reassigned to this new action. The user visible name right now is the same because:
1) i18n freeze
2) I believe this should be the standard behavior of a sync, so either they should be merged (the old action does recursive sync) or that one renamed when it is allowed.
Diffs (updated)
-----
trunk/KDE/kdepimlibs/CMakeLists.txt 1205753
trunk/KDE/kdepimlibs/akonadi/agentmanager.h 1205753
trunk/KDE/kdepimlibs/akonadi/agentmanager.cpp 1205753
trunk/KDE/kdepimlibs/akonadi/kmime/standardmailactionmanager.cpp 1205753
trunk/KDE/kdepimlibs/akonadi/resourcebase.h 1205753
trunk/KDE/kdepimlibs/akonadi/resourcebase.cpp 1205753
trunk/KDE/kdepimlibs/akonadi/standardactionmanager.h 1205753
trunk/KDE/kdepimlibs/akonadi/standardactionmanager.cpp 1205753
Diff: http://svn.reviewboard.kde.org/r/6083/diff
Testing
-------
Thanks,
Andras
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list