[Kde-pim] Review Request: Wrong quoting for ANCESTORS item

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5176/#review7281
-----------------------------------------------------------

Ship it!


Nice catch, please commit.

- Volker


On 2010-08-28 21:30:10, Jakub Stachowski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5176/
> -----------------------------------------------------------
> 
> (Updated 2010-08-28 21:30:10)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Akonadi server does not properly quote ANCESTORS item in collections. If for example username for imap account contains '\' character, then
> client will print lots of 'RID mismatch' warnings because  remote id sent in ANCESTORS item will have slash stripped.
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/akonadi/server/src/handlerhelper.cpp 1169114 
>   /trunk/kdesupport/akonadi/server/tests/unittest/handlerhelpertest.cpp 1169114 
> 
> Diff: http://reviewboard.kde.org/r/5176/diff
> 
> 
> Testing
> -------
> 
> Started KMail, noticed lack of "RID mismatch" errors.
> Also added test for this problem to handlerhelper unittest.
> 
> 
> Thanks,
> 
> Jakub
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/