[Kde-pim] Review Request: Fix selected print style for all views

Reinhold Kainhofer reinhold at kainhofer.com
Fri Apr 23 17:24:06 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3789/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

Some views were missing the print style method, so the wrong default print style was selected in the print dialog. Also, the selection of the default print style was severaly broken in the dialog, as QStackedWidget allows to add widgets with arbitrary IDs, but decides to renumber them to 1, 2, 3...., to the original IDs no longer work to select the widget...

Also added the default print style to the ::print call, rather than requiring an additional setPrintType (at which point we don't have the map of "print type ids" <=> "widget stack ids" available any more).


Diffs
-----

  trunk/KDE/kdepim/korganizer/printing/calprinter.h 1115547 
  trunk/KDE/kdepim/korganizer/printing/calprinter.cpp 1115547 
  trunk/KDE/kdepim/korganizer/views/agendaview/koagendaview.cpp 1115547 
  trunk/KDE/kdepim/korganizer/views/journalview/kojournalview.h 1115547 
  trunk/KDE/kdepim/korganizer/views/journalview/kojournalview.cpp 1115547 
  trunk/KDE/kdepim/korganizer/views/listview/kolistview.h 1115547 
  trunk/KDE/kdepim/korganizer/views/listview/kolistview.cpp 1115547 
  trunk/KDE/kdepim/korganizer/views/monthview/monthview.h 1115547 
  trunk/KDE/kdepim/korganizer/views/monthview/monthview.cpp 1115547 
  trunk/KDE/kdepim/korganizer/views/timelineview/kotimelineview.h 1115547 
  trunk/KDE/kdepim/korganizer/views/timelineview/kotimelineview.cpp 1115547 
  trunk/KDE/kdepim/korganizer/views/timespentview/kotimespentview.h 1115547 
  trunk/KDE/kdepim/korganizer/views/timespentview/kotimespentview.cpp 1115547 
  trunk/KDE/kdepim/korganizer/views/todoview/kotodoview.h 1115547 
  trunk/KDE/kdepim/korganizer/views/todoview/kotodoview.cpp 1115547 
  trunk/KDE/kdepim/korganizer/views/whatsnextview/kowhatsnextview.h 1115547 
  trunk/KDE/kdepim/korganizer/views/whatsnextview/kowhatsnextview.cpp 1115547 

Diff: http://reviewboard.kde.org/r/3789/diff


Testing
-------


Thanks,

Reinhold

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list