[Kde-pim] Review Request: Port KAlarm to KStatusNotifierItem

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3374/#review5194
-----------------------------------------------------------


I've applied the new patch, but still don't see any change to the systray icon when alarms or KAlarm are disabled or re-enabled. I did again check that the emblem icons have been installed - they are installed at

(kde_install_dir)/share/apps/kalarm/icons/oxygen/8x8/emblems/disabled.png
(kde_install_dir)/share/apps/kalarm/icons/oxygen/8x8/emblems/partdisabled.png

I would again comment that I'd prefer to see the current method of indicating that KAlarm has been disabled, i.e. a grey version of the normal KAlarm icon, since this will be more obvious at a glance.

Otherwise the patch is OK (although I'd still rather see a longer timeout provided by KSNI).

- David


On 2010-04-20 09:52:24, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3374/
> -----------------------------------------------------------
> 
> (Updated 2010-04-20 09:52:24)
> 
> 
> Review request for KDE PIM and David Jarvie.
> 
> 
> Summary
> -------
> 
> This is a port of KAlarm from KSystemTrayIcon to KStatusNotifierItem. Note that it makes use of overlays, so I created (warning, hacker "art"!) two emblems for it, which you can download here:
> http://people.canonical.com/~agateau/tmp/ox8-emblems-disabled.png
> http://people.canonical.com/~agateau/tmp/ox8-emblems-partdisabled.png
> 
> The emblems should be placed in kalarm/pixmaps/
> 
> (The ox22-emblems-partdisabled.png file from this dir can be removed)
> 
> Unfortunately, there is no way for a KStatusNotifierItem to be notified when the tooltip is about to be displayed so I had to resort to add code which updates the tooltip whenever necessary.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kalarm/kalarmapp.cpp 1106736 
>   trunk/KDE/kdepim/kalarm/kalarmconfig.kcfg 1106736 
>   trunk/KDE/kdepim/kalarm/mainwindow.cpp 1106736 
>   trunk/KDE/kdepim/kalarm/traywindow.h 1106736 
>   trunk/KDE/kdepim/kalarm/traywindow.cpp 1106736 
> 
> Diff: http://reviewboard.kde.org/r/3374/diff
> 
> 
> Testing
> -------
> 
> - Created tasks, disabled some of them, disabled the whole of kalarm: icon was correctly updated.
> - Checked the tooltip is always up to date, including when it is setup to show the remaining time of an alarm and including following tooltip preferences changes.
> 
> 
> Thanks,
> 
> Aurélien
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/