[Kde-pim] Review Request: Utility functions for recurring incidences

Allen Winter winter at kde.org
Thu Apr 29 23:52:33 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3847/#review5312
-----------------------------------------------------------

Ship it!


I really like your code.  do you intend to keep it in CalendarViews? or move it into the kcal library? or ??

I also like the idea of the multiple selector.. for example, if the user wants to keep the current selection as is, but modify the past and future occurrences.  So i'd keep that one too.

- Allen


On 2010-04-29 16:46:39, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3847/
> -----------------------------------------------------------
> 
> (Updated 2010-04-29 16:46:39)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> While trying to get rid if libkdepim dependencies I came across a special message box for asking about modifications of incidences with recurrencies.
> 
> This is an attempt to externalize this as utility functions in a namespace.
> 
> Initially I thought that a dialog with selectable modification scope would be nice as well, see screenshot. However I am not sure this is actually needed, any thoughts on this use case?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/calendarviews/agenda/recurrenceactions.h PRE-CREATION 
>   /trunk/KDE/kdepim/calendarviews/agenda/recurrenceactions.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/3847/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> questionMultipleChoice
>   http://reviewboard.kde.org/r/3847/s/379/
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list