[Kde-pim] Review Request: KMail Composer: Add dragged files as attachments without questioning

[Sascha Peilicke]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3720/
-----------------------------------------------------------

(Updated 2010-04-23 11:40:54.763819)


Review request for KDE PIM.


Changes
-------

Incorporated latest recommendations by Ingo. Updated dialog messages to use i18np.


Summary
-------

Currently, when dropping one or multiple files onto the KMail composer window, a popup dialog asks to either add the files inline or as attachments. IMHO adding inline makes little sense and other mail clients (Thunderbird, Windows Live Mail) automatically add dragged files as attachments. 

Thus this patch removes that dialog and aligns the composer's drag-n-drop behavior to the competition.


Diffs (updated)
-----

  trunk/KDE/kdepim/kmail/kmcomposereditor.cpp 1117886 

Diff: http://reviewboard.kde.org/r/3720/diff


Testing
-------

works on trunk r1117232


Thanks,

Sascha

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/