[Kde-pim] Highlighting plain-text mails (linklocator)

[Thomas McGuire]

Hi,

On Sunday 06 September 2009 16:52:57 you wrote:
> I'm back from holidays with another patch for linklocator.cpp.
> The previous patch I posted was wrong (I forgot a pair of brackets), this
>  one is good (I tested it).
> 
> It provides highlighting for words containing any kind of letter, including
> ones with diacritic (like éàç). It provides also highlighting of several
> words : *this text would be highlighted with my patch*. Last, punctuations
> marks can now be included in highlighted text : *awesome!*
> 
> Todo : it's still not possible to imbricate several highlighting syntax,
>  like that : _*This text could be bold and underlined*_
> 
> I tested my patch without compiling kmail, I just took the linklocator.cpp
> file, trimmed KDE-dependant part of the code, then modified the
>  highlihtedText function and tested it with a small Qt app until ok, then
>  reverted back KDE things trimmed at the beginning (using diff and patch).
>  I hope everything is alright.

Please extend the unit tests of linklocator to include your testcases, then it 
can be committed if no one else objects.
Extending the unit tests in the first place would have saved you from writing 
a Qt test app for this :)

Regards,
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090910/fc8405fc/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/