[Kde-pim] Review Request: non multipart MIME mails containing a single attachment shall detect attachment

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1431/#review2254
-----------------------------------------------------------

Ship it!


Seems fine, please commit.

- Thomas


On 2009-08-29 12:41:13, Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1431/
> -----------------------------------------------------------
> 
> (Updated 2009-08-29 12:41:13)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> From the bug report:
> It's quite popular to receive non multipart MIME mails containing a single attachment today, e.g. PDF invoices/delivery notices, and mails from all those Win* office users using "Mail this file".
> 
> Currently the "hasAttachment" information is not detected in that case, so no paperclip is shown in the messagelist.
> 
> This patch does check for an attachment not only in the first BodyPart but in the Message itself if it has no first BodyPart.
> 
> 
> This addresses bug 143237.
>     https://bugs.kde.org/show_bug.cgi?id=143237
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kmail/kmmessage.cpp 1015552 
> 
> Diff: http://reviewboard.kde.org/r/1431/diff
> 
> 
> Testing
> -------
> 
> With the testmails from the bug report (last 2 attachments)
> 
> 
> Thanks,
> 
> Martin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/