[Kde-pim] Review Request: Migrate settings to KConfigXT

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1536/#review2274
-----------------------------------------------------------


Looks ok, but needs some adjustments.


/trunk/KDE/kdepim/kmail/kmail.kcfg.cmake
<http://reviewboard.kde.org/r/1536/#comment1584>

    This option can be removed



/trunk/KDE/kdepim/kmail/kmail.kcfg.cmake
<http://reviewboard.kde.org/r/1536/#comment1588>

    for this and the next one, I don't think you need config labels



/trunk/KDE/kdepim/kmail/kmail.kcfg.cmake
<http://reviewboard.kde.org/r/1536/#comment1585>

    This changes the config key from header-set-displayed to headerSetDisplayed, and therefore will cause update problems.
    
    You can solve this by using
    <entry name="headerSetDisplayed" type="String" key="header-set-displayed">
    
    Please also check the other entries you changed.



/trunk/KDE/kdepim/kmail/kmail.kcfg.cmake
<http://reviewboard.kde.org/r/1536/#comment1586>

    The UI option for this is named "Prefer HTML to plain text"



/trunk/KDE/kdepim/kmail/kmail.kcfg.cmake
<http://reviewboard.kde.org/r/1536/#comment1587>

    The UI control is labeled "Allow messages to load external references from the Internet"



/trunk/KDE/kdepim/kmail/kmail.kcfg.cmake
<http://reviewboard.kde.org/r/1536/#comment1589>

    Look how the UI labels this and use the same label.



/trunk/KDE/kdepim/kmail/kmmainwidget.cpp
<http://reviewboard.kde.org/r/1536/#comment1583>

    The nestedMessages config option is not used anymore, is it?
    If so, the config option and mThreadPref should be removed.


- Thomas


On 2009-09-09 07:05:14, Torgny Nyblom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1536/
> -----------------------------------------------------------
> 
> (Updated 2009-09-09 07:05:14)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Move some settings to KConfigXT.
> 
> Never used KConfigXT before so please take a good look :)
> Also some settings have "???" as "label", what should these have instead?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.h 1021109 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1021109 
>   /trunk/KDE/kdepim/kmail/headerstyle.cpp 1021109 
>   /trunk/KDE/kdepim/kmail/kmail.kcfg.cmake 1021109 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1021109 
>   /trunk/KDE/kdepim/kmail/configuredialog.cpp 1021109 
> 
> Diff: http://reviewboard.kde.org/r/1536/diff
> 
> 
> Testing
> -------
> 
> Compiles, seems to store/read settings ok.
> 
> 
> Thanks,
> 
> Torgny
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/