[Kde-pim] Review Request: Migrate settings to KConfigXT

[Torgny Nyblom]

> On 2009-09-10 12:06:48, Thomas McGuire wrote:
> > /trunk/KDE/kdepim/kmail/kmail.kcfg.cmake, line 568
> > <http://reviewboard.kde.org/r/1536/diff/1/?file=11204#file11204line568>
> >
> >     This option can be removed

Gone


> On 2009-09-10 12:06:48, Thomas McGuire wrote:
> > /trunk/KDE/kdepim/kmail/kmail.kcfg.cmake, line 576
> > <http://reviewboard.kde.org/r/1536/diff/1/?file=11204#file11204line576>
> >
> >     for this and the next one, I don't think you need config labels

Gone


> On 2009-09-10 12:06:48, Thomas McGuire wrote:
> > /trunk/KDE/kdepim/kmail/kmail.kcfg.cmake, line 587
> > <http://reviewboard.kde.org/r/1536/diff/1/?file=11204#file11204line587>
> >
> >     This changes the config key from header-set-displayed to headerSetDisplayed, and therefore will cause update problems.
> >     
> >     You can solve this by using
> >     <entry name="headerSetDisplayed" type="String" key="header-set-displayed">
> >     
> >     Please also check the other entries you changed.

Added key="..." for these entries


> On 2009-09-10 12:06:48, Thomas McGuire wrote:
> > /trunk/KDE/kdepim/kmail/kmmainwidget.cpp, line 320
> > <http://reviewboard.kde.org/r/1536/diff/1/?file=11205#file11205line320>
> >
> >     The nestedMessages config option is not used anymore, is it?
> >     If so, the config option and mThreadPref should be removed.

Gone, it wasn't used anywhere.


- Torgny


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1536/#review2274
-----------------------------------------------------------


On 2009-09-09 07:05:14, Torgny Nyblom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1536/
> -----------------------------------------------------------
> 
> (Updated 2009-09-09 07:05:14)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Move some settings to KConfigXT.
> 
> Never used KConfigXT before so please take a good look :)
> Also some settings have "???" as "label", what should these have instead?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.h 1021109 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1021109 
>   /trunk/KDE/kdepim/kmail/headerstyle.cpp 1021109 
>   /trunk/KDE/kdepim/kmail/kmail.kcfg.cmake 1021109 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1021109 
>   /trunk/KDE/kdepim/kmail/configuredialog.cpp 1021109 
> 
> Diff: http://reviewboard.kde.org/r/1536/diff
> 
> 
> Testing
> -------
> 
> Compiles, seems to store/read settings ok.
> 
> 
> Thanks,
> 
> Torgny
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/