[Kde-pim] Review Request: Maemo fixes in Kcal

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1489/#review2240
-----------------------------------------------------------


Doesn't compile.  there must be more missing bits to the patch.

/data/kde/trunk/KDE/kdepimlibs/kcal/icalformat.cpp: In member function 'KCal::Incidence* KCal::ICalFormat::fromString(const QString&)':                                                       
/data/kde/trunk/KDE/kdepimlibs/kcal/icalformat.cpp:207: error: cannot declare variable 'cal' to be of abstract type 'KCal::CalendarLocal'                                                     
/data/kde/trunk/KDE/kdepimlibs/kcal/calendarlocal.h:44: note:   because the following virtual functions are pure within 'KCal::CalendarLocal':                                                
/data/kde/trunk/KDE/kdepimlibs/kcal/incidencebase.h:173: note:  virtual void KCal::IncidenceBase::IncidenceObserver::incidenceUpdate(KCal::IncidenceBase*)                                    
/data/kde/trunk/KDE/kdepimlibs/kcal/icalformat.cpp: In member function 'QString KCal::ICalFormat::toICalString(KCal::Incidence*)':                                                            
/data/kde/trunk/KDE/kdepimlibs/kcal/icalformat.cpp:292: error: cannot declare variable 'cal' to be of abstract type 'KCal::CalendarLocal'                                                     
/data/kde/trunk/KDE/kdepimlibs/kcal/calendarlocal.h:44: note:   since type 'KCal::CalendarLocal' has pure virtual functions                                                                   
/

- Allen


On 2009-09-02 13:07:15, Alvaro Manera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1489/
> -----------------------------------------------------------
> 
> (Updated 2009-09-02 13:07:15)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This is a combined patch of all the changes we have in our trunk, before the implementation of the RecurrenceID.
> 
> These changes include:
> * Contacts in the incidence. (I don't know if you need this, as you have the addressbook) ¿?
> * Some small fixes in our side (like copy constructor in listbase).
> * Handling the updates. This fixes the bug that you end up having a duplicate entry in the Hash table when modifying an event. 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kcal/incidencebase.h 1006190 
> 
> Diff: http://reviewboard.kde.org/r/1489/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alvaro
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/