[Kde-pim] Review Request: Maemo fixes in Kcal

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1489/#review2257
-----------------------------------------------------------


Only the patch for incidencebase.h is included - the rest of your patch is missing.


trunk/KDE/kdepimlibs/kcal/incidencebase.h
<http://reviewboard.kde.org/r/1489/#comment1547>

    This should be "@param incidenceBase a pointer to an IncidenceBase object." (Omit "is".)
    The reason is that when the API documentation is produced, the parameter names are listed in italics, with their descriptions following. Have a look at the apidox to see how this appears.
    
    The same comment applies to the other method descriptions also.



trunk/KDE/kdepimlibs/kcal/incidencebase.h
<http://reviewboard.kde.org/r/1489/#comment1548>

    Remove "is"



trunk/KDE/kdepimlibs/kcal/incidencebase.h
<http://reviewboard.kde.org/r/1489/#comment1549>

    Remove "is"


- David


On 2009-09-02 13:07:15, Alvaro Manera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1489/
> -----------------------------------------------------------
> 
> (Updated 2009-09-02 13:07:15)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This is a combined patch of all the changes we have in our trunk, before the implementation of the RecurrenceID.
> 
> These changes include:
> * Contacts in the incidence. (I don't know if you need this, as you have the addressbook) ¿?
> * Some small fixes in our side (like copy constructor in listbase).
> * Handling the updates. This fixes the bug that you end up having a duplicate entry in the Hash table when modifying an event. 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kcal/incidencebase.h 1006190 
> 
> Diff: http://reviewboard.kde.org/r/1489/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alvaro
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/