[Kde-pim] Review Request: Allow trailing '.' in domains.

Thomas McGuire mcguire at kde.org
Mon Sep 28 08:27:25 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1712/#review2476
-----------------------------------------------------------

Ship it!


Thanks, please commit, looks good.

- Thomas


On 2009-09-25 15:09:26, Torgny Nyblom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1712/
> -----------------------------------------------------------
> 
> (Updated 2009-09-25 15:09:26)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This makes KMime allow a trailing dot in domain names as per the RFC.
> Please review carefully as I'm not sure if there are any side effects to this.
> 
> 
> This addresses bug 139477.
>     https://bugs.kde.org/show_bug.cgi?id=139477
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/kmime/kmime_header_parsing.cpp 1027748 
>   /trunk/KDE/kdepimlibs/kmime/tests/headertest.cpp 1027748 
> 
> Diff: http://reviewboard.kde.org/r/1712/diff
> 
> 
> Testing
> -------
> 
> Unit tests works.
> 
> Kmail seems to display and send mails correctly.
> 
> 
> Thanks,
> 
> Torgny
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list