[Kde-pim] Review Request: adds kmail support for RFC2369, List-* headers to display in preview pane with links to URLs

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2550
-----------------------------------------------------------


I like this idea. I think there does need to be a clearer separation between the list title and "Post". Perhaps enclose the options in square brackets [Post ...].

I find the fancy header list of options rather confusing. It's not immediately obvious that the "http" and "mailto" refer to the preceding Unsubscribe and Subscribe - the fact that (Un)subscribe are not highlighted contributes to the confusion. I'd suggest making the web link the default (which is the same as Post and Archive), and show for the mail links "Unsubscribe (by mail)" and "Subscribe (by mail)". There may need to be a slightly larger spacing between the options to make it clear.

Bear in mind that ordinary users won't necessarily understand the terms "http" and "mailto" - these are technical terms for protocols - and as such they don't belong in a user interface like this.

- David


On 2009-10-04 22:59:27, Daniel Black wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
> 
> (Updated 2009-10-04 22:59:27)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs of email header fields on the view plane in kmail. The display occurs on styles: Enterprise, Fancy, Standard, and Long. The format is:
> List: Linux Australia  Post Unsubscribe(http mailto) Subscribe(http mailto) Archive Help 
> The Post, Archive and Help are links to the single URL present. The Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL protocol, are links to those two options. Only list tags that exist are show.
> Visual separation from the title and Post.... is a bit weak. Is "List: List Title <Post....>" better?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031213 
>   /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031213 
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031213 
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031213 
> 
> Diff: http://reviewboard.kde.org/r/1768/diff
> 
> 
> Testing
> -------
> 
> tested on kmail-1.12.1 (kde-4.3.1)
> 
> 
> Screenshots
> -----------
> 
> fancy style
>   http://reviewboard.kde.org/r/1768/s/219/
> enterprise style
>   http://reviewboard.kde.org/r/1768/s/220/
> standard style
>   http://reviewboard.kde.org/r/1768/s/221/
> 
> 
> Thanks,
> 
> Daniel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/