[Kde-pim] Review Request: adds kmail support for RFC2369, List-* headers to display in preview pane with links to URLs

Ingo Klöcker kloecker at kde.org
Mon Oct 5 22:48:02 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2557
-----------------------------------------------------------


Please make it optional. It might be nice to have those options available when you need them, but how often do you need them? Most of the time they are just a waste of precious vertical screen space. The current headers do already take more than enough space.

I really hope that we will soon have fully customizable preview pane layouts (via the Grantlee template system)...

- Ingo


On 2009-10-05 14:29:35, Daniel Black wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
> 
> (Updated 2009-10-05 14:29:35)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs of email header fields on the view plane in kmail. The display occurs on styles: Enterprise, Fancy, Standard, and Long. The format is:
> List: Linux Australia  Post Unsubscribe(http mailto) Subscribe(http mailto) Archive Help 
> The Post, Archive and Help are links to the single URL present. The Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL protocol, are links to those two options. Only list tags that exist are show.
> Visual separation from the title and Post.... is a bit weak. Is "List: List Title <Post....>" better?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031501 
>   /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031501 
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031501 
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031501 
> 
> Diff: http://reviewboard.kde.org/r/1768/diff
> 
> 
> Testing
> -------
> 
> tested on kmail-1.12.1 (kde-4.3.1)
> 
> 
> Screenshots
> -----------
> 
> Enterprise Style
>   http://reviewboard.kde.org/r/1768/s/224/
> Fancy Style
>   http://reviewboard.kde.org/r/1768/s/225/
> Long Style
>   http://reviewboard.kde.org/r/1768/s/226/
> 
> 
> Thanks,
> 
> Daniel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list