[Kde-pim] Review Request: Instead of negative probability, place the error message that is in the kDebug.

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1293/#review2590
-----------------------------------------------------------


This patch introduces a regression with spamassassin, which doesn't support "confidence".
I now always get "with confidence -200%", which was not there previously.

This is because the if statement in line 383 changed the meaning. before, it was "if ( confidence >= 0.0 ) ": The first branch generated a report including the confidence, the second branch generated a report without the confidence. Now it is different, the confidence is always added.

Jaime, please fix this bug.

- Thomas


On 2009-08-21 15:11:35, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1293/
> -----------------------------------------------------------
> 
> (Updated 2009-08-21 15:11:35)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Instead of negative probability, place the error message that is in the kDebug..
> 
> 
> This addresses bug 108255.
>     https://bugs.kde.org/show_bug.cgi?id=108255
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/spamheaderanalyzer.cpp 1014123 
>   /trunk/KDE/kdepim/kmail/spamheaderanalyzer.h 1014129 
>   /trunk/KDE/kdepim/kmail/headerstyle.cpp 1014123 
> 
> Diff: http://reviewboard.kde.org/r/1293/diff
> 
> 
> Testing
> -------
> 
> changed the spam header and it shows the errors in the tips.
> 
> 
> Thanks,
> 
> Jaime
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/