[Kde-pim] Review Request: KMail: Clicking the HTML status bar switches display mode

[James Bendig]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2017/
-----------------------------------------------------------

(Updated 2009-11-16 21:15:53.604513)


Review request for KDE PIM.


Changes
-------

Fixed code duplication in HtmlStatusBar::message() where Html and MultipartHtml were individually using the same message instead of sharing.
Removed line in ObjectTreeParser::processTextPlainSubType() causing multi-part messages with plain text part(s) at the end to be displayed on the html status bar as "No HTML Message."


Summary
-------

Clicking the HTML status bar in a message switches the display mode between HTML and plain text. It's implemented as an action so a user can configure a shortcut as well. Unlike as stated in the JJ, "Clicking the HTML status bar should switch display mode," the message does not have to have both HTML and plain text. Seems useful to be able to toggle back from HTML to plain text after clicking the "... activate formatted HTML display for this message by clicking here." URL.


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/htmlstatusbar.h 1048255 
  /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp 1048255 
  /trunk/KDE/kdepim/kmail/kmreaderwin.h 1048255 
  /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1048255 
  /trunk/KDE/kdepim/kmail/objecttreeparser.cpp 1048255 

Diff: http://reviewboard.kde.org/r/2017/diff


Testing
-------


Thanks,

James

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/