[Kde-pim] Review Request: KMail: Clicking the HTML status bar switches display mode

[James Bendig]

> On 2009-11-11 13:40:59, Thomas McGuire wrote:
> > Thanks for the update.
> > 
> > I find it a bit confusing that it says "No HTML message part", even though the message does have an HTML part.
> > I also think that the string is too long, with my layout, I can not see it fully.
> > 
> > Maybe just display the information that it is a mail which has both a plain text part and a HTML part in the tooltip and let the sidebar simpy display "HTML message" and "plain message"?
> > 
> > The main point that needs improvement is that place where it detects the type of the message, see the inline comment below.
> > 
> > Again, I'm very sorry for the late review, I was ill in the last days and couldn't be motivated to do anything.

I hope you're feeling better now. I was getting worried considering how fast you usually respond to reviews. :)

I tried to address your points in the third revision of the patch. Using ObjectTreeParser does feel less like a hack than the way I was checking message mime type before. I really should have found it originally.

LATE EDIT: I forgot to hit the "Publish" button when I wrote this almost five days ago. ...


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2017/#review3020
-----------------------------------------------------------


On 2009-11-11 20:19:41, James Bendig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2017/
> -----------------------------------------------------------
> 
> (Updated 2009-11-11 20:19:41)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Clicking the HTML status bar in a message switches the display mode between HTML and plain text. It's implemented as an action so a user can configure a shortcut as well. Unlike as stated in the JJ, "Clicking the HTML status bar should switch display mode," the message does not have to have both HTML and plain text. Seems useful to be able to toggle back from HTML to plain text after clicking the "... activate formatted HTML display for this message by clicking here." URL.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.h 1042445 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1042445 
>   /trunk/KDE/kdepim/kmail/objecttreeparser.cpp 1042445 
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp 1042445 
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.h 1042445 
> 
> Diff: http://reviewboard.kde.org/r/2017/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> James
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/