[Kde-pim] Review Request: keytreeview.cpp:174: warning: suggest explicit braces to avoid ambiguous 'else', keytreeview.cpp:225: warning: suggest parentheses around && within ||

[Guy Maurel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2145/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

The dashboard
  http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
reports:
/.../kdepim/kleopatra/view/keytreeview.cpp:174: warning: suggest explicit braces to avoid ambiguous 'else'
/.../kdepim/kleopatra/view/keytreeview.cpp:225: warning: suggest parentheses around && within ||

my proposal: complete with some more parentheses
see: keytreeview-gm-56.diff


Diffs
-----

  /trunk/KDE/kdepim/kleopatra/view/keytreeview.cpp 1046400 

Diff: http://reviewboard.kde.org/r/2145/diff


Testing
-------


Thanks,

Guy

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/