[Kde-pim] Review Request: echocommand.cpp:166: warning: suggest parentheses around && within ||, echocommand.cpp:166: warning: suggest parentheses around && within ||

[Guy Maurel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2143/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

The dashboard
  http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
reports:
/.../kdepim/kleopatra/uiserver/echocommand.cpp:166: warning: suggest parentheses around && within ||

at
EchoCommand::slotInputReadyRead

/.../kdepim/kleopatra/uiserver/echocommand.cpp:166: warning: suggest parentheses around && within ||

at
EchoCommand::doStart


my proposal: complete with some more parentheses
see: echocommand-gm-54.diff


Diffs
-----

  /trunk/KDE/kdepim/kleopatra/uiserver/echocommand.cpp 1046400 

Diff: http://reviewboard.kde.org/r/2143/diff


Testing
-------


Thanks,

Guy

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/